Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationView: Add more theme resources to configure margins #2923

Merged
merged 3 commits into from
Jul 21, 2020
Merged

NavigationView: Add more theme resources to configure margins #2923

merged 3 commits into from
Jul 21, 2020

Conversation

Felix-Dev
Copy link
Contributor

Description

This PR adds four new theme resources to the NavigationView:

  • NavigationViewItemMargin
  • TopNavigationViewItemMargin
  • TopNavigationViewOverflowButtonMargin
  • TopNavigationViewAutoSuggestBoxMargin

Motivation and Context

Closes #1961.

How Has This Been Tested?

Tested visually.

Screenshots:

Using XAML like

<muxc:NavigationView>
    <muxc:NavigationView.Resources>
        <Thickness x:Key="TopNavigationViewItemSeparatorMargin">2,0,0,0</Thickness>
        <Thickness x:Key="TopNavigationViewItemMargin">2,0,0,0</Thickness>
    </muxc:NavigationView.Resources>
</muxc:NavigationView>

will give us a look like this:
image

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 15, 2020
@StephenLPeters StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 15, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Felix-Dev Felix-Dev changed the title NanvigationView: Add more theme resources to configure margins NavigationView: Add more theme resources to configure margins Jul 17, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

Copying AppBarToggleButton-7.xml to d:\a\1\s\HelixOutput\UpdatedVisualTreeVerificationFiles\AppBarToggleButton-7.xml
Exception calling "DownloadFile" with "2" argument(s): "Illegal characters in path."
i see this error, perhaps related to the visual verification failures tickles that we have been seeing this week. @kmahone

@Felix-Dev
Copy link
Contributor Author

@StephenLPeters Merged with master including the fix provided by @kmahone.

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

StephenLPeters
StephenLPeters approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters StephenLPeters merged commit 86a7d62 into microsoft:master Jul 21, 2020
@Felix-Dev Felix-Dev deleted the user/Felix-Dev/navview-themeresources-margins branch July 21, 2020 21:59
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Jul 26, 2020
@Kinnara
NavigationView: Add more theme resources to configure margins (micros…
fd718cf 
…oft/microsoft-ui-xaml#2923)
@dependabot dependabot bot mentioned this pull request Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: lightweight styling for NavigationView top button spacing
3 participants
@Felix-Dev @StephenLPeters @msft-github-bot